fix: avoid mime_content_type warning on wrapped streams#592
Open
olddude2 wants to merge 1 commit into
Open
Conversation
mime_content_type() requires stream_cast() support to operate on a stream resource directly. Streams returned by File::fopen() can be wrapped in Icewind\Streams\CallbackWrapper, which does not implement stream_cast(), causing a PHP warning to be logged on every preview/output-file request even though the mime type is still detected correctly. This drains the stream into a temporary file first, then calls mime_content_type() against the file path instead. No behavior change; only removes log noise. Signed-off-by: Simon Holzman <simon.holzman@verizon.net>
Author
|
The PHPUnit / php8.2-sqlite-master failure appears to be a pre-existing Happy to rebase or make any adjustments if needed — just let me know. |
janepie
reviewed
Jul 13, 2026
| public function getOutputFilePreviewFile(string $userId, int $taskId, int $fileId, ?int $x = 100, ?int $y = 100): ?array { | ||
| $taskOutputFile = $this->getTaskOutputFile($userId, $taskId, $fileId); | ||
| $realMime = mime_content_type($taskOutputFile->fopen('rb')); | ||
| $realMime = $this->detectMimeType($taskOutputFile->fopen('rb')); |
Member
There was a problem hiding this comment.
Suggested change
| $realMime = $this->detectMimeType($taskOutputFile->fopen('rb')); | |
| $head = fread($stream, 4096); | |
| if (is_resource($stream)) { | |
| fclose($stream); | |
| } | |
| $realMime = new \finfo(FILEINFO_MIME_TYPE)->buffer($head); | |
Thank you for your contribution! Unfortunately we cannot merge this as copying the whole file to disk has a too high performance impact especially for big files. An easier fix would be to not use mime_content_type as shown above, would you be up for testing and validating if that works without any issues?
Member
|
fixes #591 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mime_content_type() requires stream_cast() support to operate on a stream resource directly. Streams returned by File::fopen() can be wrapped in Icewind\Streams\CallbackWrapper, which does not implement stream_cast(), causing a PHP warning to be logged on every preview/output-file request even though the mime type is still detected correctly.
This drains the stream into a temporary file first, then calls mime_content_type() against the file path instead. No behavior change; only removes log noise.
🤖 AI (if applicable)